codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Do we still need the typescript-json-schema dependency?

Open friedrich-roskosch-mw opened this issue 3 years ago • 1 comments

Question

It does not seem to be used anymore and the typescript-json-schema command it provides is not working and from what me and @phanlezz could gleam hasn't been working for a long time. The only use in code was in a test file from 2020 for the git log parser, and https://github.com/MaibornWolff/codecharta/pull/860 mentiones it, but we are unsure if that use case still exists.

Preparation

Please check these resources first before posting a question

Question

friedrich-roskosch-mw avatar Jul 12 '22 15:07 friedrich-roskosch-mw

The generated file is used for our validation. As such, it's important to keep the file up to date. The generation should have had a test to guarantee it does not break. We might however switch to any other validation, as long as our errors are useful. I guess there is a way to use typescript validation on the important file. The downside is that someone might depend on the json schema. But since it does not fall under our semver definition, I would just ignore that.

BridgeAR avatar Jul 21 '22 23:07 BridgeAR