codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Marked packages and black listed items are lost when switching multi <-> single file mode

Open shaman-apprentice opened this issue 4 years ago • 2 comments

Bug

Expected Behavior

Given a map in multiple file mode with colored marked packages

when switching to single file mode

then the marked packages should keep their color

Actual Behavior

Marked packages lose their color. Same goes for switching from single file to multiple file mode. Same goes for blacked listed items.

Screenshots

keep marked folder on deactivating other map

Steps to Reproduce the Problem

  1. Mark a folder in single file mode in a color
  2. Select a second file

Specifications

  • is released in online-demo: yes
  • CodeCharta Version: 1.90.0

Analysis

In multiple file mode the file name is added at the root of each path. Therefore path of marked packages and black listed items need to be updated. Some falsy calculation is already done in MarkedPackagesService and BlacklistService. Fixing this would be a good point in time to migrate this into an ngrx effect image

shaman-apprentice avatar Feb 20 '22 19:02 shaman-apprentice

This does not only apply to marked packages but also to e.g., the blacklist and similar. There is an old issue relating to this as well. It's not easy to fix this and we have to dig a bit deeper / give this further thoughts.

BridgeAR avatar Mar 11 '22 11:03 BridgeAR

can we close this as duplicate of https://github.com/MaibornWolff/codecharta/issues/476 ?

shaman-apprentice avatar Oct 28 '22 09:10 shaman-apprentice