codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

No suspicious metrics in the CodeCharta code base

Open BridgeAR opened this issue 3 years ago • 3 comments

Feature request

Description

As a CodeCharta developer, I want all buildings to have a low complexity and low suspicious metrics so that the code base is understandable and nothing obvious suspicious is visible in our own codebase.

Acceptance criteria

  • All buildings have a green mcc, smaller sizes and are well defined

Development notes (optional Task Breakdown)

Please split the work into multiple chunks that are easy to review.

BridgeAR avatar Oct 01 '21 12:10 BridgeAR

This story is meant as an epic and all code that we touch should improve situations in case where the files have non green metrics.

BridgeAR avatar Nov 03 '21 14:11 BridgeAR

I don't feel like this issue should be part of the Good First Issue Milestone. Refactoring takes time and one should understand the code base well to begin with. It is also dependent on the experience of the individual. It will be frustrating for some if they jump right into this.

In my opinion, we should leave this one out of the milestone and also decide on concrete steps to improve the metrics. For example, identify which files cause the problem for a certain metric and what we can do about it. (Basically audit CodeCharta and that would be better done with the help of someone who has done audits before)

IhsenBouallegue avatar Feb 16 '22 09:02 IhsenBouallegue

@IhsenBouallegue thanks for the input. I removed it from the milestone.

BridgeAR avatar Feb 17 '22 16:02 BridgeAR