codecharta icon indicating copy to clipboard operation
codecharta copied to clipboard

Bug collections concerning map rendering and margins

Open ce-bo opened this issue 4 years ago • 0 comments

Bug

  • When changing the margins, the height of the building should not change.
  • Refactor how we zoom the map. Currently we move the "Kegel" to zoom in and out but threejs can do that by its own (pass the zoom to threejs).
  • treeMapGenerator.js: Do not estimate the map size, calculate it: read the view port size substract some pixels to have space between the view port and the drawn map and consider the current zoom factor. The resulting numbers should be passed to threejs, so that the map fits perfectly into the view port.
  • By default all buildings should be visible (this can be achived by modifying the zoom level)

@RomanenkoVladimir @BridgeAR

Open TODOs before merge:

  • [ ] Re-enable Floor Labels
  • [ ] Add/Expand Unit Tests for area calculation
  • [ ] Fix Clipping Lane Issue (zoom out -> map disappears)

Bugs (currently in main):

  • Fix "floor labels next to the maps" after changing height scaling #2611 .
  • [ ] Map should not be moved after changing margins (zoom factor issue)

ce-bo avatar Dec 18 '20 12:12 ce-bo