hobbits icon indicating copy to clipboard operation
hobbits copied to clipboard

Edit Plugin

Open wetbadger opened this issue 3 years ago • 4 comments

Edit plugin.

With other changes to BitArray, DisplayWidget and possibly more.

Edit is a plugin for Hobbits that allows a user to directly change the data of a Bit Container.

Choose between Binary, Hexadecimal, and ASCII editing. Select a starting point and a length using the spin boxes or handlebars.

Clicking the Operate on Bits button will create a new Bit Container with the changes. You can save, delete, or further edit this Bit Container.

Right click on the display plugin and select "edit from here" to set the starting point to the bits under the mouse pointer.

wetbadger avatar Aug 05 '21 17:08 wetbadger

I did some initial review of the core file changes and some of the weird sloppiness (comments, whitespace additions). I'll check out the main plugin later.

hello-adam avatar Aug 13 '21 04:08 hello-adam

also, looks like I added some comments right above the lines I was actually talking about, so they might not make sense with the code snippets presented in the brief/thread view on this page. Sorry! I think they will make more sense on the changes page.

hello-adam avatar Aug 13 '21 04:08 hello-adam

I messed around with this a little bit and it looks pretty good. The UTF-8 stuff is the most noticeable bug right now. Another thing you should do is preserve the frames from the input container so both wide data and variable width data behaves ok.

For the variable width case, it would be nice if the frames were preserved if the edit deletes or adds something - so if the edit happens within a frame, only that frame size should change (it shouldn't spill over/into surrounding frames). IF you can't get around to that, I can probably just do it later after merging.

hello-adam avatar Aug 21 '21 20:08 hello-adam

I did not notice these comments until 2 weeks later. I am setting up hobbits again after an operating system re-installation, to work on these issues.

wetbadger avatar Aug 27 '21 17:08 wetbadger

:tada: This PR is included in version 0.54.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Feb 17 '23 01:02 github-actions[bot]