uvloop icon indicating copy to clipboard operation
uvloop copied to clipboard

fix not support python 3.11+

Open zeroday0619 opened this issue 2 years ago • 7 comments

zeroday0619 avatar Jun 02 '22 14:06 zeroday0619

When I checked again, it seems that upgrading the Cython version does not affect the previous version. thank you

zeroday0619 avatar Jun 10 '22 04:06 zeroday0619

~Fixes #465 ?~

Please add "3.11-dev" to the testing list as suggested in #459 so we have proof that this change is effective.

cclauss avatar Jul 17 '22 11:07 cclauss

Failing because of aio-libs/aiohttp#6600?

fantix avatar Jul 17 '22 15:07 fantix

#465 is still a problem on Python 3.11 beta 4.

cclauss avatar Jul 17 '22 15:07 cclauss

~~Probably... Adding this environment variable will solve the problem.~~ ~~AIOHTTP_NO_EXTENSIONS=1 ~~

aiohttp needs to update the Cython version.

zeroday0619 avatar Jul 17 '22 16:07 zeroday0619

@fantix can you enable this setting so that external contributors can run PRs? https://github.com/MagicStack/uvloop/settings/actions#actions_fork_pr_approvals_first_time_contributor_new_users

graingert avatar Jul 20 '22 10:07 graingert

Some progress... https://github.com/aio-libs/aiohttp/issues/6600#issuecomment-1203655241

It would be good to see the GitHub Actions approved on this pull request so we can see where we are at.

cclauss avatar Aug 03 '22 11:08 cclauss

I believe that for now experimentation on Py311 will require AIOHTTP_NO_EXTENSIONS=1 and --no-binary.

  • https://github.com/aio-libs/aiohttp/issues/6600#issuecomment-1229417344

cclauss avatar Aug 30 '22 05:08 cclauss

I believe that for now experimentation on Py311 will require AIOHTTP_NO_EXTENSIONS=1 and --no-binary.

  • https://github.com/aio-libs/aiohttp/issues/6600#issuecomment-1229417344

Can I add it to test code?

zeroday0619 avatar Aug 30 '22 07:08 zeroday0619

I believe that for now experimentation on Py311 will require AIOHTTP_NO_EXTENSIONS=1 and --no-binary.

Can I add it to test code?

Let's just skip aiohttp in 3.11 for now as #488 does until it supports 3.11. I'll merge in and commit this.

fantix avatar Aug 31 '22 21:08 fantix

Thanks @fantix 😁🙏

Kludex avatar Sep 01 '22 15:09 Kludex

:rocket: Can't wait for a new release :smiley:

finswimmer avatar Sep 02 '22 08:09 finswimmer

Sweet! 👏

ahopkins avatar Sep 02 '22 09:09 ahopkins

excited for this!!

KRRT7 avatar Sep 04 '22 08:09 KRRT7