Static Type-checking for httptools

[Vizonex]

I felt the need to add static type-checking to this library in order to help other programmers with using this library. I hope this pull request will help out a few people with using this library.

[Vizonex]

On Wed, Jul 17, 2024 at 5:11 AM David Grigorenko @.***> wrote:

@.**** commented on this pull request.

In httptools/parser/url_parser.pyi https://github.com/MagicStack/httptools/pull/100#discussion_r1680795353:

@@ -0,0 +1,29 @@ +from typing import Union +from array import array

+class URL:

• schema:bytes
• host:bytes
• port:int
• path:bytes
• query:bytes
• fragment:bytes
• userinfo:bytes

+def parse_url(url:Union[bytes, bytearray, memoryview, array]) -> URL:

I think you should add spaces after colons for type annotations

— Reply to this email directly, view it on GitHub https://github.com/MagicStack/httptools/pull/100#pullrequestreview-2182490074, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3K7GGVIXG426I4JPGQSNXDZMY7MVAVCNFSM6AAAAABKCSKGNSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCOBSGQ4TAMBXGQ . You are receiving this because you authored the thread.Message ID: @.***>

Thanks for your input I will make sure that I add that in.

[KRRT7]

@DABND19 could you take a look? thanks

[DABND19]

@DABND19 could you take a look? thanks

Hi! I am not the maintainer of this repository, I just left my comments on this pull request :)

[Vizonex]

thanks for the help. I was off doing other things that I had forgotten about this completely.