asyncpg icon indicating copy to clipboard operation
asyncpg copied to clipboard

Published 20 hours ago • verified publisher icon MagicStack

Support pickling Record-s

Open vmarkovtsev opened this issue 1 year ago • 3 comments

Closes #451

vmarkovtsev avatar Feb 08 '23 18:02 vmarkovtsev

@elprans Hi! Please could you kindly take a look at this PR? We've faced the same problem with difficulties of Records' pickling :(

kekekekule avatar Jul 17 '23 13:07 kekekekule

OK, we seem to have different use cases and motivations with the maintainer here. Please feel free to close this PR since I am not planning any further work, unfortunately. If one doesn't leverage custom record classes and doesn't work with nested stuff, my fork is published and maintained as asyncpg-rkt on PyPi, together with many other improvements.

vmarkovtsev avatar Aug 18 '23 07:08 vmarkovtsev

OK, we seem to have different use cases and motivations with the maintainer here

I'm not sure how you reached this conclusion. I simply pointed out the inaccuracy of your statement regarding nested records which would need to be addressed for this to get merged. Other than that this is a valid and valuable improvement.

elprans avatar Oct 09 '23 17:10 elprans