MagicPython function invocation not colored consistently

function invocation not colored consistently

Open aeschli opened this issue 6 years ago • 14 comments

bar = 1

def foo():
    pass

foo()
bar += 1

vscode

Most theme's don't colorize meta.function-call as the idea is that it should cover function names, including the full path, and all parameters (see https://www.sublimetext.com/docs/3/scope_naming.html)

I good scope to give function names is support.function

Feb 16 '18 15:02 aeschli

Is this going to be fixed any time soon? also, what about method calls? can we get these colroed as well?

Dec 05 '18 17:12 contang0

Is this going to be fixed any time soon? also, what about method calls? can we get these colroed as well?

Keep in mind for now you could highlight function calls by adding your own override in User settings by something like

    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "meta.function-call.generic",
                "settings": {
                    "foreground":"#A6E22E"
                }
            }
        ]
    }

No option to do separate method call coloring for now unfortunately.

Jan 16 '19 16:01 Adanteh

Keep in mind for now you could highlight function calls by adding your own override in User settings by something like
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "meta.function-call.generic",
                "settings": {
                    "foreground":"#A6E22E"
                }
            }
        ]
    }
No option to do separate method call coloring for now unfortunately.

@Adanteh I tried adding this to my settings.json but still no change to the function call color..

Jul 12 '19 18:07 honkeat

Keep in mind for now you could highlight function calls by adding your own override in User settings by something like
    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "meta.function-call.generic",
                "settings": {
                    "foreground":"#A6E22E"
                }
            }
        ]
    }
No option to do separate method call coloring for now unfortunately.
@Adanteh I tried adding this to my settings.json but still no change to the function call color..

@honkeat you probably placed the code in the wrong scope. It should look like this:

Jul 23 '19 08:07 contang0

@honkeat you probably placed the code in the wrong scope. It should look like this:

Still doesn't work for me. Any reason why this isn't set by default, this is the only IDE I've used with this issue.

Aug 06 '19 13:08 matt-fleming

@matt-fleming the extension "Python for VSCode" was what restricted the function coloring. After disabling it and adding the overwrite from the top everything worked fine

Aug 17 '19 14:08 mkflow27

Can we add proper instructions on the overwrite workaround? This would be very helpful.

Oct 18 '19 13:10 yeamusic21

Every function and method call is marked by meta.function-call.python scope, that includes the entire call signature. For every function and method call the name is marked by meta.function-call.generic.python or by support.function.builtin.python for builtins. The logic is that functions and methods are pretty much common bread-and-butter things that probably should be easily distinguished from builtins in most color themes. Since default color themes tend to highlight support.function but not builtin or support.function.builtin specifically that's the reason for the choices of scope names.

As for overriding the color themes, there are some instructions here. They do boil down to what has already been proposed in this thread:

    "editor.tokenColorCustomizations": {
        "textMateRules": [
            {
                "scope": "meta.function-call.generic",
                "settings": {
                    "foreground":"#A6E22E"
                }
            }
        ]
    }