MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

[Bug] Electron does not install if nodejs version is 23

Open sdetweil opened this issue 2 months ago • 4 comments

Environment

  • SYSTEM: manufacturer: System manufacturer; model: System Product Name; virtual: false; MM: 2.33.0
  • OS: platform: linux; distro: Ubuntu; release: 22.04.5 LTS; arch: x64; kernel: 5.15.0-152-generic
  • VERSIONS: electron: 38.3.0; used node: 22.20.0; installed node: 22.18.0; npm: 10.9.3; pm2: 6.0.13
  • ENV: XDG_SESSION_TYPE: x11; MM_CONFIG_FILE: undefined WAYLAND_DISPLAY: undefined; DISPLAY: :0.0; ELECTRON_ENABLE_GPU: undefined
  • RAM: total: 48077.11 MB; free: 25678.98 MB; used: 22398.14 MB
  • OTHERS: uptime: 76132 minutes; timeZone: America/Chicago

Which start option are you using?

node --run start

Are you using PM2?

No

Module

None

Have you tried disabling other modules?

  • [ ] Yes
  • [x] No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • [x] Yes

What did you do?

npm install fails when nodejs is version 23 user says

electron says only supports v22

because electron didn't install, npm start failed

What did you expect to happen?

MagicMirror to start

What actually happened?

MagicMirror wont start

Additional comments

our engines clause, doesn't block node 23

Participation

  • [ ] I am willing to submit a pull request for this change.

sdetweil avatar Oct 16 '25 14:10 sdetweil

ref https://github.com/sdetweil/MagicMirror_scripts/issues/113

sdetweil avatar Oct 16 '25 14:10 sdetweil

node v23 has reached end of live 4 months ago, so no issue for me ;)

I think we had v23 blocked in package.json, don't remember why this is not there anymore

khassel avatar Oct 16 '25 17:10 khassel

we never blocked v23, we did this with v21. From my side we can add something like "node": ">=22.18.0 <23 || >=24"

khassel avatar Oct 16 '25 17:10 khassel

I think that would be helpful, just to avoid the end confusion of successful install but no electron..

I know we did the optional on electron cause of armv6l, but that is getting harder and harder

sdetweil avatar Oct 16 '25 17:10 sdetweil