MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

[weather] add humidity to hourly view, fix spacing error when using UV Index, add config option to hide precipitation entries that are zero

Open OWL4C opened this issue 1 year ago • 5 comments

Basically the title. Just some existing weather data included into hourly, some config option ("hideZeroes") to hide precipitation when it is zero (this actually shrinks the entire table, removing columns that are completely empty), and add a spacing column to fix the UV Index column.

I don't understand why CHANGELOG.md is broken, i accidentally did my changes to my master, so i just took the current dev branch changelog and copied it into my master changelog, added my edits, and commited. This shouldn't conflict but it does

OWL4C avatar Aug 29 '24 15:08 OWL4C

automerge is turned off.. you have a conflict in the CHANGELOG.md

sdetweil avatar Aug 29 '24 15:08 sdetweil

I hope this fixed it. It may have broken my fork but that is irrelevant, the changes proposed seem fine.

OWL4C avatar Aug 29 '24 16:08 OWL4C

Thanks for your PR. Could you attach screenshot sof before and after your changes to this PR here?

rejas avatar Aug 30 '24 05:08 rejas

Currently: Screenshot 2024-08-30 at 13 07 35 All functions as mentioned: Screenshot 2024-08-30 at 13 06 54

However, the need for a spacer is purely the result of a missing css class. I have thus modified the css to include a new (placeholder) class humidity-hourly, as the humidity in the current weather would also be affected by the padding.

.weather .precipitation-amount,
.weather .precipitation-prob,
.weather .humidity-hourly,
.weather .uv-index {
  padding-left: 20px;
  padding-right: 0;
}

What is the naming convention for these classes? As soon as i know what to name the placeholder i will commit a change to remove the spacer from hourly and add the new css class. (For reference the current css without spacer would look like this: Screenshot 2024-08-30 at 13 06 28 And the css class with 20px padding looks identical to the 4em whitespace hack)

OWL4C avatar Aug 30 '24 11:08 OWL4C

I just used the placerholder as the actual class name.

OWL4C avatar Sep 10 '24 18:09 OWL4C