MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

Update compliments.js

Open devilsayshi opened this issue 9 months ago • 4 comments

Hello and thank you for wanting to contribute to the MagicMirror² project

Please make sure that you have followed these 4 rules before submitting your Pull Request:

  1. Base your pull requests against the develop branch.
  2. Include these infos in the description:
  • Does the pull request solve a related issue?
  • If so, can you reference the issue like this Fixes #<issue_number>?
  • What does the pull request accomplish? Use a list if needed.
  • If it includes major visual changes please add screenshots.
  1. Please run npm run lint:prettier before submitting so that style issues are fixed.
  2. Don't forget to add an entry about your changes to the CHANGELOG.md file.

Note: Sometimes the development moves very fast. It is highly recommended that you update your branch of develop before creating a pull request to send us your changes. This makes everyone's lives easier (including yours) and helps us out on the development team.

Thanks again and have a nice day!

devilsayshi avatar May 10 '24 08:05 devilsayshi

Hello and thanks for your PR. Please pay attention to the pre-filled text we provide for PRs. Can you be so kind and re-read it and adjust your PR accordingly?

rejas avatar May 10 '24 10:05 rejas

and you can override the list of compliments used, by adding then to your MagicMirror config.js

so the words shown are all up to you, without changing any code

sdetweil avatar May 10 '24 13:05 sdetweil

I can't see the point of this PR. The default texts are okay and the changes are not an improvement in my opinion.

KristjanESPERANTO avatar May 10 '24 16:05 KristjanESPERANTO

I agree, if the user doesnt want to see the word 'sex', they can add their own compliments strings

wait for user reply, close by end of day June 10

sdetweil avatar May 10 '24 16:05 sdetweil

you can override the list of compliments used, by adding them to your MagicMirror config.js

wait for user reply, close by end of day June 10

khassel avatar Jun 23 '24 18:06 khassel