MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

Added Specific ignoreOlderThan value (override) per URL Feature, Issue #3360

Open AartiPhatke opened this issue 2 months ago • 2 comments

Hello, I added the feature request in the newsfeed module for being able to set ignoreOlderThan for each newsfeed rather than have a global variable for it. To do this however, instead of adding an ignoreOlderThanOveride parameter, I changed ignoreOldItems and ignoreOlderThan to be arrays so they can hold values for each news feed. I also changed the logic for how these variables are accessed in generateFeed(). I also ran 'npm run test' and some of the unit tests for the calendar module were failing, I don't think this is related to my PR but I wanted to mention it. Hope this helps!

AartiPhatke avatar Apr 26 '24 20:04 AartiPhatke

it would be easier to add the variables for each feed and then use a function that returned the feed value or the default if not specified

and use that function instead of the direct value access in the genersteFeed function

sdetweil avatar Apr 26 '24 21:04 sdetweil

Hello, I made this fix!

AartiPhatke avatar Apr 26 '24 22:04 AartiPhatke