MagicMirror
MagicMirror copied to clipboard
[weather] unit of config is not respected on broadcasted notifications
Platform: All (Mainly tested on MacOS, RPI 4)
Node Version: 20.8.0
MagicMirror² Version: 2.27
Description: When the default weather module broadcasts its notification as WEATHER_UPDATED
, the imperial
units of current / forecasting temperatures (and speed of wind) is not respected. it is delivered as metric
value.
Steps to Reproduce:
/* config/config.js*/
units: "imperial",
modules: [
{
module: "weather",
position: "top_right",
config: {
weatherProvider: "openweathermap",
type: "current",
location: "New York",
locationID: "5128581", //ID from http://bulk.openweathermap.org/sample/city.list.json.gz; unzip the gz file and find your city
apiKey: "..."
}
},
...
Expected Results:
Actual Results:
Additional Notes: I knew about this issue since very early MM, but nobody has reported this issue still yet. So I do.
Hello, I would like to contribute with a solution.
@skpanagiotis ok, code it up and submit a pull request to be considered.
I have add this PR #3519 for the issue.