MagicMirror Fix for #3345 - precipitation probability not displayed when it is 0%

Fixes issue #3345.

I think I submitted this correctly, but don't do this often so let me know if anything needs to be corrected.

Jan 11 '24 19:01 vppencilsharpener

Sorry for not reviewing earlier... Might it be possible that you write a test for this?

Jan 27 '24 07:01 rejas

Sorry for not reviewing earlier... Might it be possible that you write a test for this?

I am willing, but in all honesty I have never written an automated test so there is going to be a bit of a learning curve. If I could be directed to something existing I can base it off of that would be appreciated.

Jan 28 '24 13:01 vppencilsharpener

Sorry for not reviewing earlier... Might it be possible that you write a test for this?

I am willing, but in all honesty I have never written an automated test so there is going to be a bit of a learning curve. If I could be directed to something existing I can base it off of that would be appreciated.

You can take a look at tests/e2e/modules/weather_hourly_spec.js There are tests for checking the precipitation is displayed. Your test should check if the 0 is displayed if the pop in the mocked data tests/mocks/weather_hourly.json is 0

Jan 28 '24 21:01 rejas

Merging this so the next release has it. If you find the time @vppencilsharpener you can always add a test later ;-)

Mar 21 '24 13:03 rejas