MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

Add CHANGELOG entry for dependabot PRs

Open rejas opened this issue 2 years ago • 7 comments

Currently our checks complain about the dependabot PRs since they dont add a CHANGELOG entry.

Maybe someone can look into https://github.com/dangoslen/dependabot-changelog-helper and see if it can be used to turn the PR-checks green.

rejas avatar Jan 01 '24 14:01 rejas

can take a look but do we really need this?

I'm fine with the one failing test and we can merge these PR's if all other tests are green.

I don't need every version update in the changelog, this will only blew up this file with unneeded things. For me it's o.k. to mention only significant updates as e.g. electron and have an entry dependencies updated for the normal updates (what we are doing already).

And I think we don't need this for the whole dev dependencies.

khassel avatar Jan 01 '24 15:01 khassel

as an alternative approach we could add the label Skip Changelog to the dependabot PR's to avoid the failed tests.

khassel avatar Jan 01 '24 16:01 khassel

as an alternative approach we could add the label Skip Changelog to the dependabot PR's to avoid the failed tests.

I am totally fine with this approach

rejas avatar Jan 01 '24 20:01 rejas

still not working, the Skip Changelog label is missing so check fails.

khassel avatar Jan 08 '24 18:01 khassel

maybe the PR needs to find its way to master first?

rejas avatar Jan 08 '24 19:01 rejas

so we could cherry pick it on master (will not trigger any update notifications without git tag)

khassel avatar Jan 08 '24 19:01 khassel

I you want to, you can cherrypick it. I myself wouldnt mind aiting for the next release branch.

rejas avatar Jan 14 '24 09:01 rejas