MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

v2.24.0 - Default Calendar - issue moving allday event

Open evroom opened this issue 2 years ago • 63 comments

See this topic for details:

https://forum.magicmirror.builders/topic/17318/calendar-module-problem-with-moved-allday-event-google-calendar?_=1688317001295

I could apply the workaround till v2.23.0, but not anymore on v2.24.0.

admin@MagicPi3:~ $ grep version /home/admin/MagicMirror/package.json
	"version": "2.24.0",

admin@MagicPi3:~ $ lsb_release -a
No LSB modules are available.
Distributor ID:	Raspbian
Description:	Raspbian GNU/Linux 10 (buster)
Release:	10
Codename:	buster

Using: https://calendar.google.com/

Create events:

TestCal: AllDayRepeatWeekly	--> Google Calendar: Monday 3
				--> MM Default Calendar: Monday 3

TestCal: OneDayRepeatWeekly	--> Google Calendar: Tuesday 4 - 04:00 - 05:00
				--> MM Default Calendar: Tuesday 4 - 04:00 - 05:00

Note: other recurring events (AllDayRepeatWeekly and OneDayRepeatWeekly) also on MM Default Calendar

Move events two days - 'This event':

TestCal: AllDayRepeatWeekly	--> Google Calendar: Wednesday 5
				--> MM Default Calendar: Monday 3

TestCal: OneDayRepeatWeekly	--> Google Calendar: Thursday 6 - 04:00 - 05:00
				--> MM Default Calendar: Thursday 6 - 04:00 - 05:00

Note: other recurring events (AllDayRepeatWeekly and OneDayRepeatWeekly) untouched on MM Default Calendar

Delete Recurring events - 'This event':

TestCal: AllDayRepeatWeekly	--> Google Calendar: (deleted)
				--> MM Default Calendar: Monday 3

TestCal: OneDayRepeatWeekly	--> Google Calendar: (deleted)
				--> MM Default Calendar: (deleted)

Note: other recurring events (AllDayRepeatWeekly and OneDayRepeatWeekly) untouched on MM Default Calendar

Delete Recurring events - 'All events':

TestCal: AllDayRepeatWeekly	--> Google Calendar: (deleted)
				--> MM Default Calendar: (deleted)

TestCal: OneDayRepeatWeekly	--> Google Calendar: (deleted)
				--> MM Default Calendar: (deleted)

Note: other recurring events (AllDayRepeatWeekly and OneDayRepeatWeekly) deleted on MM Default Calendar

Get events:

$ rm basic.ics; wget https://calendar.google.com/calendar/ical/xxxxxxxxx/basic.ics

--> basic.ics

Collected:

basic_AllDayRepeatWeekly.ics basic_OneDayRepeatWeekly.ics basic_MoveEvents.ics basic_DeleteEvents.ics basic_DeleteAllEvents.ics

basic_DeleteAllEvents.ics.txt basic_DeleteEvents.ics.txt basic_MoveEvents.ics.txt basic_OneDayRepeatWeekly.ics.txt basic_AllDayRepeatWeekly.ics.txt

Search an event and print complete record(s):

$ awk 'BEGIN { RS="END:VEVENT" ; ORS = "END:VEVENT\n" }/AllDayRepeatWeekly/' basic.ics

evroom avatar Jul 02 '23 17:07 evroom

may @sdetweil can look into this because he answered in the mentioned forum thread and opened an issue in https://github.com/jens-maus/node-ical/issues/234

khassel avatar Jul 02 '23 18:07 khassel

yes. I haven't had much time to find a solution. the rrule/luxon libs are returning incorrect dates

seems related to having byday in the rule (only specific days of the week)

sdetweil avatar Jul 02 '23 18:07 sdetweil

Thanks fro the quick replies. At the time, Sam provided me with 2 updated files: ical.js and calendarutils.js But the calendarutils.js file has been completely rewritten. As a result the update in ical.js alone will not do the trick.

evroom avatar Jul 02 '23 18:07 evroom

@sdetweil is this fixed with the new node-ical version?

khassel avatar Jan 01 '24 15:01 khassel