Fix weathergov api precipitationLastHour
Pull request fixes small big in weathergov api format mismatch #3124
Codecov Report
Merging #3125 (562efc0) into develop (e985e99) will increase coverage by
0.06%. The diff coverage is0.00%.
:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.
@@ Coverage Diff @@
## develop #3125 +/- ##
===========================================
+ Coverage 25.55% 25.61% +0.06%
===========================================
Files 53 53
Lines 11464 11464
===========================================
+ Hits 2930 2937 +7
+ Misses 8534 8527 -7
| Impacted Files | Coverage Δ | |
|---|---|---|
| modules/default/weather/providers/weathergov.js | 0.00% <0.00%> (ø) |
@JasonStieber can you make the requested changes?
pinging @JasonStieber in the hope he picks this PR up again
Looking into the data getting from the weather gov api there is still a property precipitationLastHour:
@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.
@rejas So we could implement a logical change to use
precipitationLast3HoursifprecipitationLastHourisnullor close this PR.
I would vote for the logical change. And you and @sdetweil ?
I would vote for the logical change.
I implemented this now.