MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

Fix weathergov api precipitationLastHour

Open JasonStieber opened this issue 2 years ago • 3 comments

Pull request fixes small big in weathergov api format mismatch #3124

JasonStieber avatar Jun 17 '23 00:06 JasonStieber

Codecov Report

Merging #3125 (562efc0) into develop (e985e99) will increase coverage by 0.06%. The diff coverage is 0.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@             Coverage Diff             @@
##           develop    #3125      +/-   ##
===========================================
+ Coverage    25.55%   25.61%   +0.06%     
===========================================
  Files           53       53              
  Lines        11464    11464              
===========================================
+ Hits          2930     2937       +7     
+ Misses        8534     8527       -7     
Impacted Files Coverage Δ
modules/default/weather/providers/weathergov.js 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

codecov-commenter avatar Jun 17 '23 08:06 codecov-commenter

@JasonStieber can you make the requested changes?

khassel avatar Sep 09 '23 21:09 khassel

pinging @JasonStieber in the hope he picks this PR up again

rejas avatar Jan 18 '24 11:01 rejas

Looking into the data getting from the weather gov api there is still a property precipitationLastHour:

grafik

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

khassel avatar Jun 22 '24 20:06 khassel

@rejas So we could implement a logical change to use precipitationLast3Hours if precipitationLastHour is null or close this PR.

I would vote for the logical change. And you and @sdetweil ?

rejas avatar Jun 24 '24 20:06 rejas

I would vote for the logical change.

I implemented this now.

khassel avatar Jun 27 '24 21:06 khassel