MagicMirror icon indicating copy to clipboard operation
MagicMirror copied to clipboard

update the magicmirror package in the npm registry

Open davide125 opened this issue 1 year ago • 10 comments

npm has a magicmirror package, but it's a very old version (2.0.0): https://www.npmjs.com/package/magicmirror . In spite of this, it seems to be actively used and downloaded (22 times in the last 7 days according to the stats). Please consider updating the npm package to the latest tagged version (and ideally keeping it up to date in the future). Thanks!

davide125 avatar Jul 02 '22 16:07 davide125

Is that a usecase at all: installing MM via npm? or what good would a package at the registry be?

rejas avatar Jul 03 '22 11:07 rejas

It makes packaging MM for Linux distros a bit easier (as they often have tooling for importing content from npm). I suspect some users might also end up installing MM from npm out of habit, as it's pretty common for node projects to use it.

davide125 avatar Jul 03 '22 15:07 davide125

well, up to @MichMich to publish a new version on npm. Not sure what he thinks...

rejas avatar Oct 03 '22 18:10 rejas

@MichMich could you give some feedback to this issue?

rejas avatar Feb 03 '23 19:02 rejas

That's a good point. I want to limit the amount of ways to install MagicMirror, due to maintenance for the contributors. But if we can find a clean solution to install using npm or yarn, I'm all for it.

The issue we had back then. Is that you couldn't install it to a specific folder using npm. Not sure if that has changed.

MichMich avatar Feb 03 '23 19:02 MichMich

I can run a npm i --prefix mm magicmirror without any problems. Not sure if that was the troublesome usecase but maybe @davide125 can weigh in on how he wants to install it (and maybe check if the current npm can isntall this old npm module)

rejas avatar Feb 04 '23 19:02 rejas

In my case I wanted to use npm as the source for packaging magicmirror in Fedora. The packaging tooling in Fedora is designed around pulling sources from npm. It's not mandatory (and I'm working around it at the moment), but it makes things much easier. If you're curious, https://bugzilla.redhat.com/show_bug.cgi?id=2103400 is where the packaging work is happening (that's at an old version for now because it still needs to pass review, I will update it to the latest before importing once it's approved and keep it up to date afterwards).

davide125 avatar Feb 05 '23 11:02 davide125

so can you check if the old version of mm install cleanly for your usecase? if so we can update the npm package to the latest version

rejas avatar Feb 06 '23 21:02 rejas

Yes, I just checked and it works fine for this. Thanks!

davide125 avatar Feb 12 '23 04:02 davide125

so might be worth updating the mm package in npm if there's no extra work needed ATM. No guaranteee for the future though, right @MichMich ?

rejas avatar Feb 12 '23 07:02 rejas