BanGDream icon indicating copy to clipboard operation
BanGDream copied to clipboard

Favorite band/song display option

Open shinylyni opened this issue 7 years ago • 8 comments

shinylyni avatar Apr 11 '17 01:04 shinylyni

Possibly, we could remove 2/3rd favorite character and replace them with these options on the profiles?

violet-r avatar Apr 11 '17 05:04 violet-r

tbh I don't really see a point to this as you could just list these in your profile description. favorite band maybe? favorite song less so

shinylyni avatar Apr 11 '17 22:04 shinylyni

Favorite characters option cannot be changed (MagiCircles specific, not BanG Dream), but I can add a tab for favorite songs similar to the favorite cards. Would that be good for you?

db0company avatar Mar 23 '18 05:03 db0company

I'm okay with both, however it be abit cluttered (though you can tell users to just not use them LOL) If this happens I'd add both either way, but my profile is pretty cluttered imo ^^;; I know it's not as cluttered in comparison to other people but it's already much for me. Honestly just an aesthetic issue on my part, since I prefer to keep things plain.

image

AmbiBambii avatar Apr 16 '18 23:04 AmbiBambii

I think both would be great, but for some people it could get cluttered, maybe tabs/dropdown bar would be awesome!

Zyobop avatar Apr 16 '18 23:04 Zyobop

I think that favorite band would be a nice thing to have on the profile links section. However if we do add it, it might be nice to keep it to just the band logo for reduced size? If possible at least.

Or maybe we could have under the user avi one of the in-game titles for each band, letting them select whichever one they want? I'm thinking around the area where you put text such as STAFF. IDK if that's possible with the framework, but it could be pretty nifty, and would not increase the size of the link area, which some feel can get quite messy.

As for songs, I think making a page similar to favorite cards would be cool too. While having one song as your favorite could be nice for some, I feel like the flexibility of showing your love to various songs would be worth a seperate page instead.

LatidoReMe avatar Apr 17 '18 02:04 LatidoReMe

To achieve this, here's what needs to be done.

On MagiCircles' repo:

  • Allow a setting for collectible to show somewhere else than under tabs but still show on profile.
  • Favorite band: Option to show owned items to profile, similar to badges and activities but in a more generic way. In other words, it would be the equivalent of collectibles, except simpler and not linked to another model like card, event, etc.

On BanGDream's repo:

  • Favorite song: Add a new model FavoriteSong and add it in collectible of SongCollection model.
  • Favorite band: Either we do what's suggested under MagiCircles and then we would be able to add a model FavoriteBand not linked to any other model, or we can also consider making Band a collection of its own instead of a choice, allowing staff to add / edit bands easily and would also solve the issue of having different images per version.

Most of these would be a bit time-consuming to make.

However, just adding FavoriteSong is doable right now pretty quickly and easily if you're fine with having it as a profile tab for now as a temporary solution.

db0company avatar Oct 09 '18 04:10 db0company

Are we giving up on favorite songs? We didn't discuss them.

db0company avatar Oct 31 '18 06:10 db0company