farasapy icon indicating copy to clipboard operation
farasapy copied to clipboard

Implemented FarasaDepParser

Open ZOUHEIRBN opened this issue 1 year ago • 3 comments

Included dependency parsing as a new module, with binary JAR downloading function from release

ZOUHEIRBN avatar Aug 03 '24 13:08 ZOUHEIRBN

Salam @ZOUHEIRBN

Thanks for your nice contribution. I have some comments to discuss..

  • I see you are putting farasa binaries in your fork in GitHub releases. This is a license violation and we have an agreement from farasa team to only consider downloading the farasa_bin from the URL they are providing. I would really advice not to continue in this direction.

In the meanwhile, I thought [following this PR: https://github.com/MagedSaeed/farasapy/pull/26] to give the ability to add a downloaded JAR for tasks that are not available in farasa_bin. So that the user can submit the request to get the JAR file from the farasa main site, get the JAR, then add its path to the task he is interested in and supported in farasapy, What do you think?

MagedSaeed avatar Aug 19 '24 12:08 MagedSaeed

Hello sir @MagedSaeed,

Thank you for considering my contribution! I think adding the ability to add custom JAR modules as a feature would provide a lot more flexibility to the program, which is in my opinion a great attribute! Especially since including the binaries in the release would be a license violation.

ZOUHEIRBN avatar Aug 19 '24 13:08 ZOUHEIRBN

@ZOUHEIRBN , can you take a look into this PR?

https://github.com/MagedSaeed/farasapy/pull/27

MagedSaeed avatar Sep 07 '24 10:09 MagedSaeed