pipenv-setup icon indicating copy to clipboard operation
pipenv-setup copied to clipboard

package update, add missing dependency chardet

Open wangsha opened this issue 3 years ago • 7 comments

wangsha avatar Oct 02 '21 14:10 wangsha

If these changes were merged, would it not cause a black version change on downstream projects?

bryant-finney avatar Oct 12 '21 04:10 bryant-finney

oops, #75 in the commit messages is actually referring to #75 in my GitLab fork haha

bryant-finney avatar Nov 08 '21 04:11 bryant-finney

The master branch now adds py38 39 310 support. The IDEA files actually have some value for intellij users, it defines a "file scope" for the source code, and a "file watcher" configuration to run black on the current file for example. Is there any rationale on using * for all the dependencies?

Madoshakalaka avatar Jul 06 '22 17:07 Madoshakalaka

I just checked and do find .idea a bit personal, it has a matt.xml that shows my vocabulary for the grammar checker for example. I'll remove it! Thanks for the suggestion!

Madoshakalaka avatar Jul 06 '22 18:07 Madoshakalaka

@Madoshakalaka I definitely version .idea, and keep this in .idea/.gitignore

/dataSources.local.xml
/dataSources/
/httpRequests/
/shelf/
/sonarlint/
/tasks.xml
/usage.statistics.xml
/workspace.xml

This explains more, from Jetbrains: https://intellij-support.jetbrains.com/hc/en-us/articles/206544839-How-to-manage-projects-under-Version-Control-Systems

Not sure about the <name>.xml, but I would imagine that's only relevant when running under <name>, so don't think it would hurt to have array of <name>s for individual contributors, personally

jshwi avatar Jul 07 '22 03:07 jshwi

@jshwi thanks, that makes sense. I learned more about .idea files despite being a 5 year intellij user :)

Madoshakalaka avatar Jul 08 '22 10:07 Madoshakalaka

@Madoshakalaka Oh I had another read, here's what they say about dictionaries:

user dictionaries folder (to avoid conflicts if other developer has the same name)

Funny, sometimes the file gets created for me, sometimes it doesn't

jshwi avatar Jul 08 '22 10:07 jshwi