pipenv-setup icon indicating copy to clipboard operation
pipenv-setup copied to clipboard

pipenv-setup check fails to handle [extras]

Open lwinkler-cloudflight opened this issue 3 years ago • 4 comments

Minimal example: hopefully enough to follow as it is an extract from a larger project.

Pipfile

[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"

[packages]
uvicorn = {extras = [ "standard",]}

pipenv-setup generates:

        "uvicorn[standard]==0.13.3",

however:

pipenv-setup check
package 'uvicorn' in pipfile but not in install_requires

expected behaviour: check can find the translated dependency.

lwinkler-cloudflight avatar Jan 27 '21 16:01 lwinkler-cloudflight

Hi, I solved this issue and followed the contributing guide ... then, tried to add a pull request but I don't have permission to do so. Hope the creator of this repo will contact me. And maybe I'm just doing something wrong (created a branch after cloning, then when I try to push the branch to create a pull request, I get access denied)

shaybensasson avatar Jun 05 '21 12:06 shaybensasson

Hi @shaybensasson ,

I would advise creating the PR from a fork of this repo (as described here)

bryant-finney avatar Oct 31 '21 12:10 bryant-finney

@shaybensasson

this looks like a quick-win, I was considering looking into this but if you have found a fix please push a PR from your fork! :smile:

jshwi avatar Nov 22 '21 10:11 jshwi

#94 Here you go

shaybensasson avatar Dec 06 '21 19:12 shaybensasson