pipenv-setup
pipenv-setup copied to clipboard
pipenv-setup check fails to handle [extras]
Minimal example: hopefully enough to follow as it is an extract from a larger project.
Pipfile
[[source]]
url = "https://pypi.python.org/simple"
verify_ssl = true
name = "pypi"
[packages]
uvicorn = {extras = [ "standard",]}
pipenv-setup generates:
"uvicorn[standard]==0.13.3",
however:
pipenv-setup check
package 'uvicorn' in pipfile but not in install_requires
expected behaviour: check can find the translated dependency.
Hi, I solved this issue and followed the contributing guide ... then, tried to add a pull request but I don't have permission to do so. Hope the creator of this repo will contact me. And maybe I'm just doing something wrong (created a branch after cloning, then when I try to push the branch to create a pull request, I get access denied)
@shaybensasson
this looks like a quick-win, I was considering looking into this but if you have found a fix please push a PR from your fork! :smile:
#94 Here you go