pipenv-setup icon indicating copy to clipboard operation
pipenv-setup copied to clipboard

Keyword dependency_links is not found

Open xoxys opened this issue 4 years ago • 5 comments

check command will fail if dependency_links is not present in setup.py. Is it intended that we need an (empty) dependency_links=[] in setup.py to get the ckeck command passed?

xoxys avatar Mar 01 '20 17:03 xoxys

It's not intended, can I have some more details? Do you have vcs packages e.g. git package in your Pipfile/Pipfile.lock? If so, and you have the package in install_requires using the new PEP 508 syntax. This bug might happen. pipenv-setup does not know the new syntax yet. But it is being implemented.

Madoshakalaka avatar Mar 01 '20 17:03 Madoshakalaka

Nope, no vcs packages in Pipfile. But maybe I miss something but you can take a look at your own. https://github.com/xoxys/docker-tidy/blob/master/Pipfile

xoxys avatar Mar 01 '20 17:03 xoxys

@xoxys thanks, I'll investigate this!

Madoshakalaka avatar Mar 01 '20 17:03 Madoshakalaka

Cool. Thanks for your work!

xoxys avatar Mar 01 '20 17:03 xoxys

Just to confirm this issue is still present - let me know if I can help

inverse avatar Feb 02 '21 09:02 inverse