Android-Material-Icon-Generator icon indicating copy to clipboard operation
Android-Material-Icon-Generator copied to clipboard

Allow to set custom svg background shape

Open AleksanderMielczarek opened this issue 8 years ago • 6 comments

It would be nice to set two icons. One for foreground (as it is now) and second for background (in addition to current circle and square). What do you think about this idea?

AleksanderMielczarek avatar Apr 26 '16 17:04 AleksanderMielczarek

Great, I like it. Are you thinking about creating a pull request regarding this?

Maddoc42 avatar Apr 26 '16 19:04 Maddoc42

I'd love to contribute, but JS is not my thing.

AleksanderMielczarek avatar Apr 26 '16 20:04 AleksanderMielczarek

Thanks for the comment anyways :) I'll keep this open in case anyone feels like tackling this one, it shouldn't be too hard.

A couple of notes on how this could look like:

  • Menu 'Background shape' should have three check boxes: [ ] circle, [ ] square, [ ] custom
  • When 'custom' is selected have the icon picker appear in the menu on the left, similar to how the dev / beta banner colors appear

Maddoc42 avatar Apr 27 '16 08:04 Maddoc42

Hey @AleksanderMielczarek. Even though this thread is a little old by now, would you mind elaborating what background shapes you would like to use? Are those shapes custom to your application or are you simply looking for more options, like star, heart, etc? :+1:

Maddoc42 avatar Jan 18 '17 17:01 Maddoc42

Hi,

in this particular case I was looking for background in this shape (it has holes but it's ok, foreground for sure covers it). After all I used circle shape.

I don't know how hard would it be to implemented background chooser similar to foreground (circle, rectangle, Google icons and custom icon from local disc). Ideally with filled holes.

AleksanderMielczarek avatar Jan 18 '17 20:01 AleksanderMielczarek

Ok, makes sense, thanks for the explanation :+1:

In theory not so super hard. It gets more complicated if that is combined with the score effect.

In any case, the issue stays :)

Maddoc42 avatar Jan 18 '17 21:01 Maddoc42