Chris Cowan

Results 131 comments of Chris Cowan

Right now, you can make jest-puppeteer load jest-puppeteer.config.js from the same directory as jest.config.js by putting this in your jest.config.js: ```js process.env.JEST_PUPPETEER_CONFIG = require.resolve('./jest-puppeteer.config.js'); ``` (I'd love it if this...

After studying this project and using its .proto file, I previously made a webpage-based Stream Deck plugin that connects to the Rust+ API. It's not super clean code as the...

I don't think we should expose `InboxSDK.setInjectScriptImplementation()` and make it the user's responsibility like this. I'd rather that the injectScriptImplementation inside src/platform-implementation-js/lib/inject-script.ts checked if the browser was Firefox (maybe just...

The injectScriptImplementation() function inside src/platform-implementation-js/lib/inject-script.ts already has a path where it falls back to loading the script through adding a script tag to the page, so it would be a...

@wegry brought to my intention that the injectScriptImplementation() function inside `src/platform-implementation-js/lib/inject-script.ts` is set up to avoid including any references to direct script injection so we don't fail some certain Chrome...

This looks like a useful example! I'm not sure we want to merge it into the main branch here though. We could link to it as a separate github repo...

The Filebase client library issue was fixed (https://github.com/filebase/filebase-js/issues/3) so it's been re-enabled in this PR.

I assume this is intended as a stepping stone toward not bundling the InboxSDK at all. It seems like this would switch us to publishing using ESM instead of CommonJS....

It's been in each version I've tested so far, including 0.94.4 (2022-05-14).