MachineMusePowersuits icon indicating copy to clipboard operation
MachineMusePowersuits copied to clipboard

[1.10.2] Issues

Open lehjr opened this issue 8 years ago • 119 comments

These are the currently known issues (will be updated as things change )in the current build: Some future release:

  • Look into replacing opengl calls with GLStateManager calls.
  • Revisit block breaking code and cleanup/optimize. Also need to check and make sure things are actually working properly.
  • Change the precision of sliders to allow for better rounding of values. Current setup is notoriously horrible when trying to get a nice round number. ( I think I can do it, started it, will go back to it) see: https://github.com/MachineMuse/MachineMusePowersuits/issues/758
  • look into adding a "fortune upgrade" to the powerfist. see here: https://github.com/MachineMuse/MachineMusePowersuits/issues/759
  • look into silk touch upgrade: https://github.com/MachineMuse/MachineMusePowersuits/issues/797
  • thermal generator module install cost needs to be fixed
  • Alternate Tinker table. The iconic model had to be butchered to deal with rendering glitches. To make up for it, I would like to move the model to a JSON type so that players can replace it with one of their own from resource packs.
  • particle trails because why not. This may be put on hold until rendering issues can be worked out. https://github.com/MachineMuse/MachineMusePowersuits/issues/654
  • wireless terminal modules for Refined storage (want to rewrite a little bit): https://github.com/MachineMuse/MachineMusePowersuits/issues/782
  • wireless terminal module for AE2: clean up code a little. Postponed for now
  • Elytra flight will be on hold for a bit. It's a bit too complicated to deal with at the moment. There's a pr in progress for forge that will make things easier. Waiting to see how that goes first. Other solutions are possible, but terrible.

lehjr avatar Mar 11 '17 18:03 lehjr

Ah, and fix the speed boost (the actual speed doesn't even change, doesn't matter the value set in the tinker table). Tool modules (shears, leaf blower and lux capacitor) are crashing the game when used.

Desempregago avatar Mar 14 '17 18:03 Desempregago

Just telling me things are crashing is meaningless without logs

lehjr avatar Mar 14 '17 18:03 lehjr

"Ah, and fix the speed boost " You're gonna have to be a lot more specific than that.

lehjr avatar Mar 14 '17 18:03 lehjr

The speed boost doesn't change, actually it works even if I uninstall the module (salvage)

Desempregago avatar Mar 14 '17 18:03 Desempregago

About the lux capacitor crash

Description: Tesselating block model

java.lang.IndexOutOfBoundsException: Index: 1, Size: 1 at java.util.ArrayList.rangeCheck(Unknown Source) at java.util.ArrayList.get(Unknown Source) at net.minecraft.client.renderer.vertex.VertexFormat.func_177344_b(SourceFile:90) at net.minecraft.client.renderer.VertexBuffer.func_178962_a(VertexBuffer.java:408) at net.minecraft.client.renderer.BlockModelRenderer.renderQuadsFlat(BlockModelRenderer.java:390) at net.minecraft.client.renderer.BlockModelRenderer.func_187497_c(BlockModelRenderer.java:154) at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.func_187497_c(ForgeBlockModelRenderer.java:86) at net.minecraft.client.renderer.BlockModelRenderer.func_187493_a(BlockModelRenderer.java:72) at net.minecraft.client.renderer.BlockModelRenderer.func_178267_a(BlockModelRenderer.java:52) at net.machinemuse.powersuits.client.render.entity.EntityRendererLuxCapacitorEntity.doRender(EntityRendererLuxCapacitorEntity.java:49) at net.machinemuse.powersuits.client.render.entity.EntityRendererLuxCapacitorEntity.func_76986_a(EntityRendererLuxCapacitorEntity.java:24) at net.minecraft.client.renderer.entity.RenderManager.func_188391_a(RenderManager.java:398) at net.minecraft.client.renderer.entity.RenderManager.func_188388_a(RenderManager.java:375) at net.minecraft.client.renderer.RenderGlobal.func_180446_a(RenderGlobal.java:811) at net.minecraft.client.renderer.EntityRenderer.func_175068_a(EntityRenderer.java:1741) at net.minecraft.client.renderer.EntityRenderer.func_78471_a(EntityRenderer.java:1566) at net.minecraft.client.renderer.EntityRenderer.func_181560_a(EntityRenderer.java:1345) at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1076) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371) at net.minecraft.client.main.Main.main(SourceFile:124) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310) at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:394) at org.multimc.EntryPoint.listen(EntryPoint.java:170) at org.multimc.EntryPoint.main(EntryPoint.java:54)

Desempregago avatar Mar 14 '17 18:03 Desempregago

Shears and any other "tool" module crash Description: Unexpected error

java.lang.ClassCastException: net.minecraft.item.ItemShears cannot be cast to net.minecraft.item.ItemTool at net.machinemuse.powersuits.powermodule.tool.ToolHelpers.isEffectiveTool(ToolHelpers.java:34) at net.machinemuse.powersuits.powermodule.tool.ShearsModule.canHarvestBlock(ShearsModule.java:119) at net.machinemuse.powersuits.event.HarvestEventHandler.handleBreakSpeed(HarvestEventHandler.java:36) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_486_HarvestEventHandler_handleBreakSpeed_BreakSpeed.invoke(.dynamic) at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:90) at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:185) at net.minecraftforge.event.ForgeEventFactory.getBreakSpeed(ForgeEventFactory.java:172) at net.minecraft.entity.player.EntityPlayer.getDigSpeed(EntityPlayer.java:859) at net.minecraftforge.common.ForgeHooks.blockStrength(ForgeHooks.java:206) at net.minecraft.block.Block.func_180647_a(Block.java:532) at net.minecraft.block.state.BlockStateContainer$StateImplementation.func_185903_a(BlockStateContainer.java:399) at net.minecraft.client.multiplayer.PlayerControllerMP.func_180511_b(PlayerControllerMP.java:240) at PlayerControllerOF.func_180511_b(PlayerControllerOF.java:43) at net.minecraft.client.Minecraft.func_147116_af(Minecraft.java:1459) at net.minecraft.client.Minecraft.func_184117_aA(Minecraft.java:2179) at net.minecraft.client.Minecraft.func_184118_az(Minecraft.java:1961) at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1749) at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1055) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:371) at net.minecraft.client.main.Main.main(SourceFile:124) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source) at java.lang.reflect.Method.invoke(Unknown Source) at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310) at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:394) at org.multimc.EntryPoint.listen(EntryPoint.java:170) at org.multimc.EntryPoint.main(EntryPoint.java:54)

Desempregago avatar Mar 14 '17 18:03 Desempregago

which "speed boost" are you referring to

lehjr avatar Mar 14 '17 18:03 lehjr

and which version are you using?

lehjr avatar Mar 14 '17 18:03 lehjr

By speed boost, I mean the leg module, and I'm using the latest 1.10.2 version (Alpha 005)

Desempregago avatar Mar 14 '17 18:03 Desempregago

There should be no problem with that. I was just using it fine a few minutes ago.

lehjr avatar Mar 14 '17 19:03 lehjr

But it's weird that the speed boost is still being applied even after module removal

Desempregago avatar Mar 14 '17 19:03 Desempregago

Also mentioned was that tinkering it to have more or less effect doesn't apparently work. It's the same amount of speed boost.

I haven't tested this myself.

eyeonus avatar Mar 14 '17 19:03 eyeonus

/\ This.

Desempregago avatar Mar 14 '17 19:03 Desempregago

I just tried it again myself, even recorded it. I am not seeing what you are describing at all. Edit: video here: https://vimeo.com/208369919

lehjr avatar Mar 14 '17 19:03 lehjr

If I can't reproduce it, I can't fix it.

lehjr avatar Mar 14 '17 19:03 lehjr

Weird... On my client, the game crashes with a Tesselating Model exception when I shoot a Lux Capacitor

And the speed boost doesn't change at all, doesn't matter the level or setting

Desempregago avatar Mar 14 '17 19:03 Desempregago

What mods do you have installed?

lehjr avatar Mar 14 '17 19:03 lehjr

Modlist

Desempregago avatar Mar 14 '17 19:03 Desempregago

Interesting. That's a long list and will be time consuming to replicate. Do you have Industrialcraft installed? And are you using anything like Optifine?

lehjr avatar Mar 14 '17 19:03 lehjr

wait, I do see optifine. That might be the cause of the crash for the lux capaicitor. I'll have to try it out later.

lehjr avatar Mar 14 '17 19:03 lehjr

I'm not using IC2, OptiFine U7 (latest)

Desempregago avatar Mar 14 '17 19:03 Desempregago

Well, I was able to replicate the issue with the speed assist module with IC2 removed. I'll have to spend some time on that to figure it out.

lehjr avatar Mar 14 '17 19:03 lehjr

Testing confirmed that the lux capacitor crash is caused by Optifine. Unfortunately, a fix will be time consuming due to the inability to use optifine in a development environment.

lehjr avatar Mar 14 '17 23:03 lehjr

This is why I just don't use optifine.

eyeonus avatar Mar 15 '17 00:03 eyeonus

Agreed, but I'll still try and fix it anyway. I didn't find any other issues with optifine, but I didn't do much testing either. The code that's causing issues is likely to change anyway because the animation is horrible. Instead of a smooth flight, the lux capacitor zig zags all over until it lands.

lehjr avatar Mar 15 '17 00:03 lehjr

OK, so I have a fix for the optifine crash, and I think for the tool crash as well. The sprint assist module will need more work. I'm not entirely sure of cause of the issue yet.

lehjr avatar Mar 15 '17 01:03 lehjr

New alpha is up

lehjr avatar Mar 15 '17 01:03 lehjr

@Fogrits I'll be looking at the sprint assist module today and with any luck, the fix should be in the next alpha.

lehjr avatar Mar 17 '17 12:03 lehjr

Still working on that sprint assist, but no one noticed the swimming boost didn't actually boost your speed in the water? :P

lehjr avatar Mar 17 '17 17:03 lehjr

Haven't gone in the water yet. Still working on getting the jet pack modules installed in my game. Don't have much time on workdays.

eyeonus avatar Mar 17 '17 17:03 eyeonus