MachineMusePowersuits
MachineMusePowersuits copied to clipboard
MachineMuse
Full localization support
Still a lot of stuff is hardcoded. Including GUI elements and item tooltips. Please, only close this when everything will be translatable. This issue is a more like reminder to you @MachineMuse :)
Press SHIFT for more information. MuseCommonStrings.java everything from here All this stuff Stuff in .xml files This probably require a rework of all this stuff -_-
Continuation of #516
Added to the first post. It just starting. I'll search for more stuff tomorrow :)
ok, thanks.
You're right that some of this would require a rework of those systems so I'm not really thrilled about that idea. The models especially were designed to be something that players can contribute to and have custom ones easily, but nobody did :(
Models? Didn't know that feature.... By the way an updated in-game wiki book with MPS features and similar or an updated wiki for MPS is needed once MPS is released. If I remember correctly, MPS addons has partially added a Book.
yeah some documentation would probably have helped with that. ^^' oh well.
@MachineMuse After thinking a bit, it's maybe not required to rewrite everything. I suggest you this system: 1) create folders armor and modelspec. 2) move .xml files to these folders and rename them to language codes (en_US.xml). 3) create in these folders folder "Custom" where custom models can be placed. Here an example how to make .xml files translatable: https://github.com/SlimeKnights/TinkersConstruct/commit/fb4c0ddf9e05d03fa871300eb9df91524d3610df It should be different from yours but it's should be possible.
P.S @MachineMuse can you switch experimental branch to default?
the main problem is that the name is stored in the nbt tags, so if these things are changed, it would appear incorrectly for people using different locales on the same server.
The simplest solution would be to just make them display in the GUI with locales (could do this with 1-2 lines changed), but the locale data would have to be added to the main file in the lang folder as far as I know, and that wouldn't support custom models in any case.
Then maybe you can separate supported models from custom? So, supported will be stored in main lang file but custom will stay in .xml.
So far, I guess the only thing left that cannot be localized is item tooltips. I hope this can be finished in the future versions. @MachineMuse
