libmacchina icon indicating copy to clipboard operation
libmacchina copied to clipboard

Published 20 hours ago • verified publisher icon Macchina-CLI

OperatingSystem implementation for Linux

Open be4zad opened this issue 1 year ago • 2 comments

It seems operating system name is same with distro name. Isn't it better to remove GeneralReadout::distribution() and replace it by GeneralReadout::os_name()?

be4zad avatar May 09 '24 14:05 be4zad 

behzad@arch ~> hostnamectl
Operating System: Arch Linux 
…

be4zad avatar May 09 '24 15:05 be4zad

I made that distinction in the API to accommodate the differences in semantics between operating systems. Operating systems built on Linux refer to themselves as distributions and the API reflects that, whether that was the right choice is debatable. I just don't think it's worth breaking backwards-compatibility for such a minor problem.

grtcdr avatar May 10 '24 20:05 grtcdr