Code Review: startup.m2, Core.m2, and last.m2

[mahrud]

This is not a pull request, but rather a hack to use GitHub's features for performing a collaborative code review. If this works well, I'm hoping to also look at parts of the interpreter later. Alternatively, if anyone knows of a collaborative tool for reviewing existing code (i.e. not reviewing a diff but a whole file), that would be very welcome!

Specifically with an eye towards future pull requests and refactoring, my goals are to:

1. go through each section/variable/function in the three files,
2. explain what is the purpose of that code is/was, and
3. discuss whether
   • that purpose is still necessary, otherwise delete the section, or
   • we would do it differently or more effectively now.

Basically imagine if someone submitted a pull request to add these files and your task is to be the reviewer.

Here is how to participate:

1. click on "Files changed" tab above
2. click on "Load diff" for any of the files
3. read any part of the code and if you have questions about it, leave a comment
4. answer any questions that you are familiar with below

Tagging people who have changed these files: @DanGrayson @mikestillman @d-torrance @pzinn

[mahrud]

@DanGrayson do you have time to help answer any of the questions here?

[DanGrayson]

@DanGrayson do you have time to help answer any of the questions here?

No, sorry!

[mikestillman]

I get back from France tomorrow (late), I'll take a look.

[mahrud]

Seems like code review is not a priority.