M2 icon indicating copy to clipboard operation
M2 copied to clipboard

What's the point of `isQuotientRing`?

Open mahrud opened this issue 1 year ago • 3 comments

https://github.com/Macaulay2/M2/blob/86d6c70f8746e6b13d95c53ad20d880e0d60a8dc/M2/Macaulay2/m2/quotring.m2#L9-L12 It would make sense if, for instance, isQuotientRing(QQ[x,y]/x) returned false after flattening the ring, but as it is implemented it seems pointless and counter-intuitive:

i3 : isQuotientRing (ZZ/3)

o3 = true

i4 : isQuotientRing (ZZ/3[x])

o4 = false

I say pointless because it might as well not be a method at all:

isQuotientRing = R -> class R === QuotientRing

mahrud avatar Dec 01 '23 02:12 mahrud

You make good points. Get rid of it.

DanGrayson avatar Dec 01 '23 17:12 DanGrayson

What if instead it did this?

isQuotientRing = R -> instance(minimalPresentation R, QuotientRing)

mahrud avatar Dec 01 '23 18:12 mahrud

Thats's a good idea, but remove the application of minimalPresentation -- why waste time in a computation?

DanGrayson avatar Dec 01 '23 21:12 DanGrayson