M2
M2 copied to clipboard
What's the point of `isQuotientRing`?
https://github.com/Macaulay2/M2/blob/86d6c70f8746e6b13d95c53ad20d880e0d60a8dc/M2/Macaulay2/m2/quotring.m2#L9-L12
It would make sense if, for instance, isQuotientRing(QQ[x,y]/x) returned false after flattening the ring, but as it is implemented it seems pointless and counter-intuitive:
i3 : isQuotientRing (ZZ/3)
o3 = true
i4 : isQuotientRing (ZZ/3[x])
o4 = false
I say pointless because it might as well not be a method at all:
isQuotientRing = R -> class R === QuotientRing
You make good points. Get rid of it.
What if instead it did this?
isQuotientRing = R -> instance(minimalPresentation R, QuotientRing)
Thats's a good idea, but remove the application of minimalPresentation -- why waste time in a computation?