MacPass doesn't keep icon/text preference in toolbar

[rghedin]

Describe the bug When I click in MacPass' toolbar and select “Icon Only”, it reverts my preference back to the default (“Icon and Text”) when I lock the screen or close and reopen my MacBook's lid.

To Reproduce

1. Right click on MacPass' toolbar.
2. Select “Icon Only”.
3. Lock the screen (Cmd + Ctrl + Q) or close the noebook's lid.
4. Wait for a few seconds.
5. Login again, and the toolbar will be showing “Icon and Text” instead of my previous preference (“Icon Only”).

Expected behavior Keep “Icon Only” or whatever toolbar layout selected.

Desktop (please complete the following information):

• macOS: 12.3.1
• Version: 0.8.1 (26030)

[mstarke]

Since the data stored for toolbar setup is entirely done by AppKit I have no real clue why do you see this behaviour. Can you try to show the prefs by running the following in Terminal:

defaults read com.hicknhacksoftware.MacPass "NSToolbar Configuration MainWindowToolbar"

[mstarke]

If you change something, the values should change as well so if there's something not working this seems like a problem with defaultsd

[rghedin]

{
    "TB Default Item Identifiers" =     (
        "TOOLBAR_ADD_ENTRY",
        "TOOLBAR_DELETE",
        "TOOLBAR_ADD_GROUP",
        "TOOLBAR_AUTOTYPE",
        "TOOLBAR_ACTION",
        NSToolbarFlexibleSpaceItem,
        "TOOLBAR_SEARCH",
        NSToolbarFlexibleSpaceItem,
        "TOOLBAR_LOCK",
        "TOOLBAR_INSPECTOR"
    );
    "TB Display Mode" = 1;
    "TB Icon Size Mode" = 1;
    "TB Is Shown" = 1;
    "TB Item Identifiers" =     (
        "TOOLBAR_SEARCH",
        NSToolbarFlexibleSpaceItem,
        "TOOLBAR_ACTION",
        "TOOLBAR_LOCK",
        "TOOLBAR_INSPECTOR"
    );
    "TB Size Mode" = 1;
}

When I change the toolbar settings, option "TB Display Mode" = 1; changes to "TB Display Mode" = 2;. But if I lock the screen and log back in, "TB Display Mode" = 1; comes back.

[mstarke]

I’m about to get a machine with macOS 12 so I might be able to shine some light on the issue.