MacPass icon indicating copy to clipboard operation
MacPass copied to clipboard

UI improvement: make selected / deselected options more distinct in generator

Open drawcard opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. The on/off states aren't clear enough when used in combinations. Dark tints usually indicate that something is inactive, however in this interface it indicates when something is active.

For example, it's clear that "0-9" is the only setting here: CleanShot 2022-02-18 at 13 44 31@2x

But in this case, it looks like "A-Z" is the only enabled setting (because it's brighter than the rest of the actual selected buttons) CleanShot 2022-02-18 at 13 45 54@2x

It becomes more confusing when some are toggled and some aren't: CleanShot 2022-02-18 at 13 46 38@2x

Describe the solution you'd like A clear and concise description of what you want to happen.

It would be good to have more visual distinction when an option is active (eg a green tick symbol next to the button label, eg:

CleanShot 2022-02-18 at 13 51 57@2x CleanShot 2022-02-18 at 13 54 54@2x

Other idea - colour change only Selected buttons could also be a green tint to indicate they are active.

Or alternatively, reverse the grey colour scheme, so active buttons are brighter than inactive.

drawcard avatar Feb 18 '22 03:02 drawcard

You could also just remove the border of the unchecked buttons. This way selecting an option would result in it having a border and being colored in a darker shade.

ArkitectNaut avatar Feb 19 '22 08:02 ArkitectNaut

I tend to stay away from custom UI since it adds additional drag to the development. MacPass is quite old and has seen a lot of UI changes on macOS so this bit me rather hard in the a***. Thus I do try to stick to native UI. It might be useful to switch to a different style of buttons that show the states more accurately.

mstarke avatar Feb 21 '22 14:02 mstarke