react-director-admin-template icon indicating copy to clipboard operation
react-director-admin-template copied to clipboard

hmm....some naming issues in current version

Open rednaxus opened this issue 7 years ago • 2 comments

Hey, nice piece of work... but I just pulled this and it wouldn't compile until I fixed it because some names of directories and files are out of whack

    src/app/components/label/label.js
        src/app/components/tabPanel/TabPanel/TabPanel.js
    src/app/components/tabPanel/TabPanelBodyContent/tabPanelBodyContent.js
    src/app/views/simpleTables/simpleTables.js

should be:

src/app/components/label/Label.js
src/app/components/tabPanel/tabPanel/
src/app/components/tabPanel/tabPanelBodyContent/
src/app/views/simpleTables/SimpleTables.js

rednaxus avatar Jan 22 '18 23:01 rednaxus

Nice Rednaxus. I fixed this issue before I read it

A1Darkwing avatar Mar 23 '18 09:03 A1Darkwing

Thank you @rednaxus for the tip, you saved my day. I guess the issue mainly manifests on Linux and not on MacOS (as filenames on MacOS are not case-sensitive).

Here is what I had to run in a single shot to fix it. (based on Rendaxus's note)

cd ./src/app/
mv ./components/label/label.js ./components/label/Label.js
mv ./views/simpleTables/simpleTables.js ./views/simpleTables/SimpleTables.js
mv ./components/tabPanel/TabPanelBodyContent  ./components/tabPanel/tabPanelBodyContent
mv ./components/tabPanel/TabPanel ./components/tabPanel/tabPanel
mv ./components/tabPanel/tabPanelBodyContent/tabPanelBodyContent.js  ./components/tabPanel/tabPanelBodyContent/TabPanelBodyContent.js

Ideally this should be fixed in the repo as well, so others wont encounter the issue.

kefahi avatar Apr 20 '18 15:04 kefahi