ember-cli-sortable icon indicating copy to clipboard operation
ember-cli-sortable copied to clipboard

Build failing on Ember 2.12

Open laantorchaweb opened this issue 7 years ago • 5 comments

Maybe related to having Ember moved away from bower_components, but it's throwing this error:

Error: Cannot find module '/bower_components/ember/ember-template-compiler'
at Class.module.exports.htmlbarsOptions (/node_modules/ember-cli-sortable/node_modules/ember-cli-htmlbars/ember-addon-main.js:70:25)

laantorchaweb avatar Apr 21 '17 18:04 laantorchaweb

Hey, @MaazAli any ideas about how to solve this issue? If I make a PR can you merge and publish?

laantorchaweb avatar Jun 15 '17 19:06 laantorchaweb

having same issue Ember version 2.14.1. Any fix for that?

ghost avatar Aug 28 '17 11:08 ghost

@laantorchaweb did you find any solution plz share.

ghost avatar Aug 28 '17 11:08 ghost

I'm no longer maintaining this addon, it is very likely that it no longer works!

MaazAli avatar Aug 29 '17 02:08 MaazAli

Hello,

Sorry to comment on this thread again, even though you meant that this is not longer maintained. But this addon is being used in one of our project's and by many of them as well.

So I took the privilege, in upgrading the addon to 2.12, fixing the eslint issues, and writing a small working example of the addon.

Also, I have updated the index.js file, to include _findHost hook. So this support ember-engine's application as well.

I have raised a PR. Could you please validate them and merge it.

Warm Regards.

SanthoshRaju91 avatar Jan 12 '18 07:01 SanthoshRaju91