Update _spacy.py, Working with the new ._.trf_data object (3.7+)

Open 2513502304 opened this issue 7 months ago • 3 comments

What does this PR do?

Fixes # (issue)

Before submitting

[x] This PR fixes a typo or improves the docs (if yes, ignore all other checks!).
[ ] Did you read the contributor guideline?
[ ] Was this discussed/approved via a Github issue? Please add a link to it if that's the case.
[ ] Did you make sure to update the documentation with your changes (if applicable)?
[ ] Did you write any new necessary tests?

May 05 '25 11:05 2513502304

Thanks for the PR and your work on this.

Did you check the Before submitting? I'm missing the related issue where this was discussed.

May 21 '25 10:05 MaartenGr

This is a fix for spaCy version compatibility. I don't seem to have found any discussion about the related issue in this repository, but in the spaCy repository, you can find the discussion about this issue here. You can find the relevant pipeline design here.

May 21 '25 14:05 2513502304

I meant an issue within BERTopic. Typically, it is discussed first over there and validated before moving over to a PR. Now, it is not entirely clear to me when this issue appears and how to reproduce it.

That said, could you share some code to reproduce this issue? Also, I noticed some commented-out code. Are you planning to do something with that?

May 30 '25 13:05 MaartenGr