Maarten

Results 76 comments of Maarten

But the current configure already define `_FILE_OFFSET_BITS=64` So `lseek`, `fseeko` and others are already 64-bit. Or am I missing something? Are there still platforms that do not support this (but...

In CMake it is indeed not defined, see https://github.com/wxWidgets/wxWidgets/issues/22750. I have a fix locally already, I'll try to publish a PR soon.

I created #23336 that enables `HAVE_LARGEFILE_SUPPORT` in CMake.

I have a few comments. Maybe you could create a PR, that makes commenting on it a bit easier. And it will allow the CI to test it. * make...

> No reason to skip MSVC explicitly. gettext is part of vcpkg and that's what we use this patch with (MSVC+vcpkg). Making gettext optional would be the way to go....

Scintilla can't be backported to 3.2. Because 3.2 is compatible with c++98, and Scintilla in the master branch requires c++11. But maybe only the relevant changes can be backported. I'll...

Seems like a bug in wxWidgets, not Scintilla. I compiled master with Scintilla 3.7.2 (the one used in 3.2 branch) and it works fine. When I run the stc sample...

It was fixed by fcc7430610ca202b744df75dc3d7e471a1e8b8a4 `Set wxALWAYS_NATIVE_DOUBLE_BUFFER to 1 to wxMSW too`. I don't think we can just apply that to 3.2, because it assumes all other double buffering and...

Maybe something else to look at. Is the `wxStyledTextCtrl` correctly identified as Scintilla control? Spy++ says the classname of `wxStyledTextCtrl` will be `wxWindow` with window caption `stcwindow`. https://github.com/nvaccess/nvda/blob/6d97c5a8b74bc423c13a218b7575b2b7be8858e9/source/NVDAObjects/window/__init__.py#L121-L122 ``` elif...

I can reproduce it too with a monitor setup like in the image from @asmwarrior I can fix drawing on the main monitor by using: ```c++ rect.x += GetSystemMetrics(SM_XVIRTUALSCREEN); rect.y...