FF8_demaster icon indicating copy to clipboard operation
FF8_demaster copied to clipboard

InjectMonsterAtlasResolution - not so dynamic at all + uses const addresses, so unusable for JP

Open MaKiPL opened this issue 1 year ago • 0 comments

texture.h:28

inline constexpr DWORD DEFAULT_MONSTER_ATLAS_TEX_RESOLUTION = 0x180;

texturepatch_v2_battleHooks.cpp:73

void InjectMonsterAtlasResolution(const DWORD monsterTexResolution)
{
	OutputDebug("InjectMonsterAtlasResolution::Injecting atlas resolution of: %d\n", monsterTexResolution);
	InjectDWORD(IMAGE_BASE + 0x1606D9D+6, monsterTexResolution*2);
	InjectDWORD(IMAGE_BASE + 0x1606DAE+6, monsterTexResolution*2);
	InjectWORD(IMAGE_BASE + 0x16051D1+1, static_cast<WORD>(monsterTexResolution));
}
  • [X] 1. It uses constant addresses without caring for JP version
  • [ ] 2. The const 0x180 works in most cases, but breaks for groups of monsters. The resolution should be dynamic

MaKiPL avatar Aug 27 '24 12:08 MaKiPL