DefineOutside

Results 49 comments of DefineOutside

I disagree with automatically parsing WrappedBlockState due to the additional memory this would add when loading this class.

considering old viaversion doesn't support protocollib 5.0 I don't see this as an issue. Additionally, old ProtocolSupport no longer breaks PacketEvents, so this isn't an issue.

this does make sense because of stuff like WrappedBlockState using ClientVersion confusing people.

Maybe this was fixed by adventure changes? This should be tested.

Still able to reproduce this error

Fixed by https://github.com/retrooper/packetevents/commit/ce484ecac53ec16806f88e827613335ea4755dbf

closing because you seem to have fixed it with https://github.com/retrooper/packetevents/commit/67eaa912525490df157071e66d73c1b9c3b4d9d7

Other players will see the pose but the client will revert this immediately on the next tick. This seems hacky and PoseChangeEvent might be a better thing. There should also...