MWDelaney
Remove function call that seems to be generating unwanted output.
I'm not completely sure because I was actually experimenting with just using this single shortcode (supported by the utilities) in another plugin, but it looks like the line I removed was making the shortcode run twice, as well as generating output in the admin, before headers.
If not, sorry for the noise, man.
Hmm... This part might need to be rethought. I definitely need it to run do_shortcode() on the $content, incase $content contains more shortcodes, but if it's echoing them that's not what we want.
Might need to buffer output? I'll take a look as soon as I can.
I just discovered [using templates in plugins](https://konstantin.blog/2013/get_template_part-within-shortcodes https://konstantin.blog/2013/get_template_part-within-shortcodes) that way and like it a lot.
Feels very MVC.
On Mar 30, 2018, at 8:55 AM, Michael W. Delaney [email protected] wrote:
Hmm... This part might need to be rethought. I definitely need it to run do_shortcode() on the contents, incase those contents contain more shortcodes, but if it's echoing them that's not what we want.
Might need to buffer output? I'll take a look as soon as I can.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MWDelaney/bootstrap-4-shortcodes/pull/9#issuecomment-377529300, or mute the thread https://github.com/notifications/unsubscribe-auth/AGGJx6PK1rM8u7eBFPvdHCLSmVcICrtlks5tjjlmgaJpZM4TBVvW.
It would be super interesting (and super time consuming) to set all the shortcodes up as templates. If we used Gamajo-Template-Loader we could even do theme overrides...
It would require a lot of rework.