Maarten Vercruysse
Maarten Vercruysse
Doing your way would require huge changes to the codebase. Currently all checks that require auth just check if there is account. Which would have to change. And we would...
Support for outdated servers is not hard for 0.17.X. But a proper one is. Like described in here https://github.com/dessalines/jerboa/pull/908#discussion_r1246175005 . Dessalines doesn't want the current "hack" that would allow backwards...
Not really, atm i'm not fully sure what happens when you swap or start the app with a account that is on a version that is no longer supported. I...
I had another FR somewhere that allowed you to make anon users for every instance
it probably should do it from the get go, regardless
@twizmwazin what do you think?
https://github.com/dessalines/jerboa/blob/4fc09124b8db64b1b18cb70f5d913ebb21605970/app/src/main/java/com/jerboa/ui/theme/Sizes.kt#L31-L32 We do have currently a limit. I think the bigger problem is that we dont enforce this for non pictrs image links https://github.com/dessalines/jerboa/blob/4fc09124b8db64b1b18cb70f5d913ebb21605970/app/src/main/java/com/jerboa/Utils.kt#L442-L462
This is not fixed for non pictrs pictures. And is not enforced. Pictrs could return bigger. version than we request and we would display that.
This is possibly caused bc the scrollbar size is based of the size of the lazycolumn (the comment tree), this size constantly changes as comments get moved into view (increased)...
It's not impossible to fix, if this is the cause we can simple use the postRes or listState to retrieve the true size i believe. I would need to take...