OpenMU icon indicating copy to clipboard operation
OpenMU copied to clipboard

Bugfix/joh upgrade

Open ze-dom opened this issue 1 year ago • 1 comments

  • Added required item level check for item option upgrade (was only present in option addition)
  • Added required item level check for Item option power up activation (the client also grays out the option if this is not met)
  • Added ancient item requirement check for JoH application (reference 1, §3-1; reference 2)
  • Updated excluded items list for Lower Refining Stone crafting (reference)
  • Updated requirements for Higher/Lower Refining Stones crafting (reference)
  • Added new plugin RefineStoneUpgradeConsumeHandlerPlugIn.cs to encompass the particular rule of max dmg - min damage >= 1 (reference)
  • Updated Higher/Lower Refining Stones and JoH success rates (reference 1, §3-6; reference 2)
  • Fixed item fail result for Higher/Lower Refining Stones -> reset to base option level (can be 0, 3, 6 or 9)
  • Added requirement for Personal Store opening to exclude JoH'ed items, since these can't be traded (reference)
  • Fixed some JoH options values (reference)
  • Fixed restore item crafting ItemCraftingRequiredItem properties

P.S.: JoH options also have weights (reference). I think this should be added too, but since it involves a migration and DB data, I wanted to check with you first :)

ze-dom avatar Oct 21 '24 11:10 ze-dom

Hey, thanks for all these corrections :) Sure, if you want to add these randomization weights, just go for it.

sven-n avatar Oct 21 '24 12:10 sven-n

Hey, I found a failing unit test: JewelOfLifeFailReducesOptionLevelAsync. May these changes be the reason? ;)

sven-n avatar Nov 24 '24 14:11 sven-n