MMapper icon indicating copy to clipboard operation
MMapper copied to clipboard

fix sanitizer to replace control characters with a question mark

Open nschimme opened this issue 2 months ago • 1 comments

This fixes corrupted user maps with a "River Lh\x00n" room name.

Summary by Sourcery

Map ASCII control characters including NUL to the default unmapped character ('?') during sanitization and charset insertion.

Bug Fixes:

  • Sanitizer now replaces NUL (and other control characters) with '?' in one-line, multiline, and word-wrapped output
  • BasicCharsetInserter now maps ASCII control code points to the default unmapped character instead of passing them through

Tests:

  • Add test_nul to verify NUL is replaced with '?' in sanitizeOneLine, sanitizeMultiline, and sanitizeWordWrapped

nschimme avatar Oct 30 '25 18:10 nschimme

🧙 Sourcery has finished reviewing your pull request!


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an issue from a review comment by replying to it. You can also reply to a review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull request title to generate a title at any time. You can also comment @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in the pull request body to generate a PR summary at any time exactly where you want it. You can also comment @sourcery-ai summary on the pull request to (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the pull request to resolve all Sourcery comments. Useful if you've already addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull request to dismiss all existing Sourcery reviews. Especially useful if you want to start fresh with a new review - don't forget to comment @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

  • Contact our support team for questions or feedback.
  • Visit our documentation for detailed guides and information.
  • Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

sourcery-ai[bot] avatar Oct 30 '25 18:10 sourcery-ai[bot]