capturetheflag icon indicating copy to clipboard operation
capturetheflag copied to clipboard

Use voxel manip for barrier placing commands

Open a-blob opened this issue 1 year ago • 2 comments

a-blob avatar Jan 29 '24 03:01 a-blob

Have you benchmarked that this is actually substantially faster? Barriers are a bit special because they are relatively sparse. VoxelManip can't offer sub-mapblock granularity. So with this PR, you'd be loading & setting at least 15 non-barrier blocks for each barrier block. This may very well offset any performance gains from using VoxelManip.

appgurueu avatar Mar 11 '24 15:03 appgurueu

The main problem with the current one is not speed, but that the barriers will have holes if a chunk within the selected area is not rendered when it's placing the barriers. image

a-blob avatar Mar 12 '24 03:03 a-blob

@LoneWolfHT I think so

a-blob avatar Jun 17 '24 05:06 a-blob