capturetheflag icon indicating copy to clipboard operation
capturetheflag copied to clipboard

Add Death Message

Open 165135 opened this issue 2 years ago • 12 comments

Send death message to a player after they die telling them who killed them and who assisted in the kill. Can be toggled on and off in the Inventory Settings tab.

165135 avatar Jul 11 '23 19:07 165135

You are doing well young programmer ;)

farooqkz avatar Jul 11 '23 19:07 farooqkz

I did not know that #n puts the PR link and name... I know now XD

165135 avatar Jul 11 '23 22:07 165135

image For some reason, its showing the setting multiple times

165135 avatar Jul 12 '23 04:07 165135

Okay, I think the three time setting register is because functions.lua is somehow running 3 times, possibly, idk if this is me understanding something wrong or intentional image

165135 avatar Jul 12 '23 06:07 165135

Oh I'm silly its called from the three gamemode init.luas

165135 avatar Jul 12 '23 07:07 165135

@farooqkz Did I miss something that needed to be changed?

165135 avatar Jul 14 '23 06:07 165135

@farooqkz Did I miss something that needed to be changed?

Just tested. It's almost okay. There is a small typo which I'm gonna make suggestion for it. after you committed my suggestion, I will mark it as ready for review.

farooqkz avatar Jul 14 '23 07:07 farooqkz

@LoneWolfHT I haven't reviewed the code logic yet.

farooqkz avatar Jul 14 '23 08:07 farooqkz

@165135 I tested this a long time ago. Does it also say how much score your killer got?

farooqkz avatar May 20 '24 21:05 farooqkz

I didn't even remember that this existed but ok

165135 avatar May 23 '24 00:05 165135

What do you think about also showing how many points were given for killing you? https://discord.com/channels/447819017391046687/1008040841102766153/1218686930833768612

Suggestion: On the death screen, show "<player_name> killed you for <points> points!"

LoneWolfHT avatar Jun 26 '24 19:06 LoneWolfHT

Oh, I guess #1306 already does that

LoneWolfHT avatar Jun 26 '24 19:06 LoneWolfHT