capturetheflag icon indicating copy to clipboard operation
capturetheflag copied to clipboard

give score for items removed from enemies

Open farooqkz opened this issue 2 years ago • 16 comments

This PR gives score to the players if they put an item dropped from teammate or enemy and put it in the teamchest. The item must not be stackable.

farooqkz avatar Jul 03 '23 16:07 farooqkz

What stops players from just cashing in all the items they've collected and talking it all back from the chest as soon as they get the points?

AltZ-15 avatar Jul 03 '23 17:07 AltZ-15

What stops players from just cashing in all the items they've collected and talking it all back from the chest as soon as they get the points?

It's a reasonable concern. But why they would do that?

farooqkz avatar Jul 03 '23 17:07 farooqkz

To play it safe I would prefer to only give 1 or less score for items we reward returning, and slowly increase that as we watch things play out on the main server

LoneWolfHT avatar Jul 03 '23 19:07 LoneWolfHT

To play it safe I would prefer to only give 1 or less score for items we reward returning, and slowly increase that as we watch things play out on the main server

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

farooqkz avatar Jul 04 '23 07:07 farooqkz

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

Did you read the and slowly increase that as we watch things play out on the main server part? The item values can be differentiated again as we increase them

LoneWolfHT avatar Jul 06 '23 13:07 LoneWolfHT

I disagree with the reward being the same, one point, for all the items. And less than one is a bad idea IMO

Did you read the and slowly increase that as we watch things play out on the main server part? The item values can be differentiated again as we increase them

Yeah I know but it doesn't make sense to me even temporary. But if you mean some stuff can be temporary non-sensible, that's your decision. I am committing to give exactly one for all items.

farooqkz avatar Jul 06 '23 15:07 farooqkz

Thanks. https://github.com/MT-CTF/capturetheflag/pull/1173#discussion_r1254898943 needs to be fixed and this will be ready for testing

LoneWolfHT avatar Jul 06 '23 20:07 LoneWolfHT

Your rebase didn't work at all there

LoneWolfHT avatar Jul 28 '23 17:07 LoneWolfHT

With rebasing I tend to use git rebase -i <PR branch>~<number of previous commits I want to have the option to squash> (e.g git rebase -i master~6), squash all my commits together, then git pull -r mainrepo master to rebase off of the CTF repo's master branch

I'm laying that out to show you some things you can do, I highly recommend googling/figuring out what those commands do on your own though, you can seriously mess things up otherwise

LoneWolfHT avatar Jul 28 '23 17:07 LoneWolfHT

Items returned to team chest shouldn't give score if they're your own

LoneWolfHT avatar Jul 29 '23 15:07 LoneWolfHT

@LoneWolfHT Done.

farooqkz avatar Aug 03 '23 15:08 farooqkz

Rebase conflict

WDYM?

farooqkz avatar Aug 11 '23 18:08 farooqkz

image

LoneWolfHT avatar Aug 19 '23 18:08 LoneWolfHT

@LoneWolfHT Done

farooqkz avatar Aug 20 '23 11:08 farooqkz

How are you rebasing your PR? This shouldn't be showing up: image

LoneWolfHT avatar Aug 21 '23 16:08 LoneWolfHT

@LoneWolfHT What was state of this? Do I need to do anything?

farooqkz avatar Feb 11 '24 14:02 farooqkz