capturetheflag
capturetheflag copied to clipboard
MT-CTF
Introduce Landmines
This PR aims to add landmines to CTF. The landmine is triggered and explodes when a player walks on it and it damages enemies inside a radius of ~3 nodes. Craftable with 4 steel ingots and one frag grenade. Can be found in treasure chests, cannot be triggered by and does not damage team mates.
@xenonca Please add a description to the PR, explaining how the landmines work, how to craft, how to place, the damage caused, and other stuff we should take note of. Thanks.
I'm not sure how useful landmines will be. For me they feel slow, and an enemy can easily run over them. I think we should test them with more people and get their feedback.
If nobody objects I'll go ahead and ping Testers on Discord for this purpose
I'm not sure how useful landmines will be. For me they feel slow, and an enemy can easily run over them. I think we should test them with more people and get their feedback.
If nobody objects I'll go ahead and ping Testers on Discord for this purpose
Let's start the testing phase. 👍
Emm, when I enter into the game and try to test it the game kick me so... I can't test it if first thing I see is how it kicks me
Emm, when I enter into the game and try to test it the game kick me so... I can't test it if first thing I see is how it kicks me
Posting the reason that got you "kicked" would be useful in solving your problem.
Emm, when I enter into the game and try to test it the game kick me so... I can't test it if first thing I see is how it kicks me
Posting the reason that got you "kicked" would be useful in solving your problem.
I went to get on the landmine and it kicked me
Emm, when I enter into the game and try to test it the game kick me so... I can't test it if first thing I see is how it kicks me
Posting the reason that got you "kicked" would be useful in solving your problem.
I went to get on the landmine and it kicked me
Kicked you as in kicked you from the game? What's the message you got?
I think I know what that might have been, @Lucyucy pointed out a bug to me a few days ago, I'll try to fix it soon.
I'm not sure how useful landmines will be. For me they feel slow, and an enemy can easily run over them. I think we should test them with more people and get their feedback.
Just like Spikes. The problems that it checks every X second rather than having an event which triggers when the player gets to a certain distance.
But I think Landmines will be better than Spikes. At least no friendly damage.
I think I know what that might have been, @Lucyucy pointed out a bug to me a few days ago, I'll try to fix it soon.
Has it been fixed? I would really like to see landmines IG and I tried to help but it seems @xenonca doesn't want to accept help and do the job all themselves.
@farooqkz your reasoning is untrue. I rejected your PRs because they did not solve the mentioned issues and the damage/trigger calculation was too inaccurate (as I explained here), not because I don't want to accept any help. I'll update the PR when I have the time to implement the fix in my fork. The PR has a WIP label for a reason.
-
There seems to still be debug stuff in the chat
-
Since you can place landmines in enemy territory it might be a good idea to color-code them to teams. This should be possible using a mask and [multiply
I made a pr with a different method of checking for players. Still testing locally. -edit- If a intentional explosion is triggered the explosion will injure players on both teams. and since I'm testing in conjunction with my freeze mod I'm finding a few bugs in it. Also just realized that if you are stuck frozen for too long you get kicked :D
Github has the Draft PR feature. So I think it's a good idea to remove the label and make this PR a draft.
There seems to still be debug stuff in the chat
- Since you can place landmines in enemy territory it might be a good idea to color-code them to teams. This should be possible using a mask and [multiply
I would like to fix these stuff on the behalf of @xenonca. Is that possible?
I would like to fix these stuff on the behalf of @xenonca. Is that possible?
You could do a code change suggestion in a review
I would like to fix these stuff on the behalf of @xenonca. Is that possible?
You could do a code change suggestion in a review
Yeah but I want landmines in game and it is taking too long for Xenon to progress.
Hey, I'm aware that this PR is advancing extremely slowly. I'm currently quite busy with RL stuff which is keeping me from finishing this. I'm sorry that the landmines PR isn't progressing at the pace you'd wish it would. If you don't mind, I would still like to work on the PR as I initiated the idea. Help in the form of code reviews/suggestions is always welcome though.
All of us are busy with real life stuff and this project is a hobby of us. So not contributing for a while or even longer is natural. Since my early days of CTF(as a player mostly), there are many who have come and gone. As an obvious example rubenwardy is long gone and LV/LW has replaced him.
Now regarding your idea and contribution, I would really love to see this thing in game. If you don't agree with someone else continuing your work, then I won't interfere except for suggestions and code reviews. But I humbly ask you to let someone else continue this. The progress is not complicated, someone will fork your fork, make required changes and then merge it into this repo. The commits which were yours are still yours. Some new commits will include this though.
Look, I'm not a dev and have barely some programming skills. :P I've surprisingly come up with a good idea that I believe would add to the gameplay and so I'd like to be the one who gets it done too. There are like a ton of other things that need to be done for CTF and you're free to come up with your own ideas at any time or contribute to existing PRs (in the form of suggestions/reviews). I don't quite understand why you want to adopt this specific PR so much, more than anything else.
...it is taking too long...
I'm aware of that, but players in game aren't even really aware of the PR really so I don't see a real reason to rush here. I think the day it gets added to the game will be the same for the players any time, no matter if that'll happen tomorrow, in 2 weeks or in a month. As I've already said, I would still like to continue this PR, however, there will be nothing stopping you from opening your own PR.
There seems to still be debug stuff in the chat
- Since you can place landmines in enemy territory it might be a good idea to color-code them to teams. This should be possible using a mask and [multiply
Debug should be gone now. I'm wondering what would be the best solution. Add team masks or limit the placement of landmines to the team's territory. That would also add a little risk (in a positive way?) when stepping on it, similar to how damage cobble works.
Look, I'm not a dev and have barely some programming skills. :P I've surprisingly come up with a good idea that I believe would add to the gameplay and so I'd like to be the one who gets it done too. There are like a ton of other things that need to be done for CTF and you're free to come up with your own ideas at any time or contribute to existing PRs (in the form of suggestions/reviews). I don't quite understand why you want to adopt this specific PR so much, more than anything else.
...it is taking too long...
I'm aware of that, but players in game aren't even really aware of the PR really so I don't see a real reason to rush here. I think the day it gets added to the game will be the same for the players any time, no matter if that'll happen tomorrow, in 2 weeks or in a month. As I've already said, I would still like to continue this PR, however, there will be nothing stopping you from opening your own PR.
The problems that I'm both a player here and a code contributor. As a player, I would love to see landmines in game. And as a programmer, when I see you are just one epsilon away from finishing your work, while I can do it in a trivial time to finally see it in game, I have a lust to finish your work and finally have it in game. It'll be still your work plus a little bit help from me.
The idea of landmine was proposed in the early days of CTF in #35 and much later I, unknowingly, made a duplicate(#150).
P.S.: Coming up with good ideas for gameplay is one thing and implementing it is another thing. One might come up with very good ideas but with no programming skills. And someone like me would come with several bad ideas but with strong programming background. For a list of them you can see my messages in the related channel in Discord. And the issues I opened in this repo in the days of rubenwardy :)
@LoneWolfHT I believe I don't have permission to suggest changes. Or that I am overlooking something.
@LoneWolfHT I believe I don't have permission to suggest changes. Or that I am overlooking something.
Select a section of code, click that and then edit the code that appears in your comment box
@LoneWolfHT How long should before someone else could take the job by forking Xenon's fork, making changes and creating a PR to this repo?
@LoneWolfHT How long should before someone else could take the job by forking Xenon's fork, making changes and creating a PR to this repo?
Wait until they agree it'll take to long for them to finish it themselves
JFYI, I never claimed to be the first one suggesting this idea, but apparently the one who actually started the PR for it.
I feel like I had already clarified my point in my last message: I do want to finish this myself, even if it will take me longer than it would probably take you. However, there won't be anything stopping you from opening your own PR if you insist. The way you urge me to finish this PR instead of contributing by making useful suggestions is getting annoying and honestly makes me feel uncomfortable. I'm wasting more time and resources into this discussion and repeateing myself than into the actual PR.
I'm sorry @xenonca if you've made uncomfortable. It seems I am rushing way too much. I've made some suggestions. I hope they will be useful :)