Matthew Sevey
Matthew Sevey
Next Steps on this issue should be to do a code audit since it has been a year and there has been a lot of updates. Result of the audit...
``` ./types/header.go:96: // TODO: There must be a way to verify non-adjacent headers ./types/test_utils.go:11:// TODO: accept argument for number of validators / proposer index ./types/state.go:7: // TODO(tzdybal): copy to local...
Is this a new Workflow or updating an existing one? If existing, can you link to the file so we know which one we are looking at?
Since this is a relatively nuanced why of keeping backwards compatibility I would recommend you add some comments to the top of the `_old` files and their corresponding files that...
Created issue here as a tracker.
> So, I added a rendered link to the PR description with rendered specs readme and realized that linking between symlinks defined in the specs folder and the actual specs...
> @MSevey, try clicking links to Components on the rendered page and you will see oh right, yea we've talked about this internally. The Github UI doesn't support symlinks, but...
@Wondertan the specs site https://celestiaorg.github.io/go-header/ to make it work with both I would just not link to the specs folder. the specs folder is essentially a wrapper to enable a...
> > So to make it work on the GH UI we just shouldn't reference the specs folder outside the specs folder. > > @MSevey, Do you mean pointing to...
Can you add it to the github workflow matrix so we can see the failures in CI? https://github.com/celestiaorg/knuu/blob/8d1b00fcae71de633bf5236bbec903d4b859303d/.github/workflows/knuu_testing.yml#L14 Can you share what the failures are that you are seeing locally?