Matthew Seal

Results 380 comments of Matthew Seal

I can quickly implement this if others are ok with the change.

format schema is found at https://github.com/jupyter/nbdime/blob/master/nbdime/diff_format.schema.json ``` In [9]: orig = nbformat.read("binder/process_highlight_dates.ipynb", as_version=4) In [10]: new = nbformat.read("binder/process_highlight_dates_new.ipynb", as_version=4) In [11]: diff_notebooks(orig, new) Out[11]: [{'op': 'patch', 'key': 'cells', 'diff': [{'op':...

There's not anyone taking on improving the diffing story in the open source atm that I'm aware of. https://github.com/jupyter/nbdime/issues/468 would enable an easy way to generate the diffs for CI...

I believe that was the intention for git support. I agree that having an abstract object store would help support this. Do you think we should be consolidating the abstract...

And that would add a python 3 only dependency. We could release the package with only blocking methods on python2 and async + blocking methods in python3 perhaps?

Or make an async package wrapping the blocking package for use in async python 3 clients

For papermill python 2 downloads is declining (26398 vs 105360 over past 6 months), but are still present. https://docs.google.com/spreadsheets/d/1tkNxlxY-qlZATGpqC1IxDE30mwDW8Uedfov3KcH3iJk/edit?usp=sharing

I marked python 2 as supported through the end of 2019 for papermill and scrapbook in the latest release's README for each project respectively. Sometime at the end of the...

The intention of the idea was to give the option on automatic saves or publish to be able to publish a clean version of the notebook. But unlike git, we're...

That does appear to be a hard-coded value. This file predates my time with the project (and hasn't anything but a linting fix in 4 years!), but I believe it...