MSP-Greg
MSP-Greg
Interesting. I'll see if I can repo.
@nateberkopec I'd agree, but I'm also not familiar with automated licensing tools, so I'm not much help. Not sure about the differences between the MIT and 'BSD 3-Clause' licenses. Not...
@nateberkopec Thanks. The current PR adds `set_encoding`, I think adding `external_encoding` and `internal_encoding` would also be a good idea. I'll update soon...
@dentarg Re the minissl commit, I may revert that. Still doing work re the JRuby issue, as both failures in the CI run here successfully completed the tests. Also, there...
Just ran CI in my fork with master and the work branch I've got this code in. Ran both in my fork, since I have an individual 'Pro' account, I...
@dentarg Thanks for your comments. I haven't recently had the time to work on this that I'd like, including looking at your comments. I rebased on master, and some odd...
@jmuia Haven't had time to think about this, but one question: > it's a common pattern to fail healthcheck requests for N seconds prior to draining existing connections and closing...
@dentarg > I see what this does (and if you only call call on this object this change shouldn't be breaking, right?) Correct. The only requirement (from the Rack spec)...
Added links to this PR and the related issue to the new test.
I just rebased and added another test that I only tested locally on Ubuntu. Locally, it fails on master, passes with this PR. Of course, just to make things fun,...